fix(glob): report "not found" for missing search paths - #21
Open
9d2z12gwzutihg wants to merge 2 commits into
Open
fix(glob): report "not found" for missing search paths#219d2z12gwzutihg wants to merge 2 commits into
9d2z12gwzutihg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globpath validation withgrep: missing paths returnError: … not foundinstead of the misleadingis not a directory.Problem
When the model passes a bad directory to
glob, the current message suggests a type mismatch rather than a missing path.grepalready distinguishes these cases.Test plan
test_glob_nonexistent_pathandtest_glob_path_is_filepytest tests/test_tools.py -q