Skip to content

fix(glob): report "not found" for missing search paths - #21

Open
9d2z12gwzutihg wants to merge 2 commits into
he-yufeng:mainfrom
9d2z12gwzutihg:fix/glob-missing-path-error
Open

fix(glob): report "not found" for missing search paths#21
9d2z12gwzutihg wants to merge 2 commits into
he-yufeng:mainfrom
9d2z12gwzutihg:fix/glob-missing-path-error

Conversation

@9d2z12gwzutihg

Copy link
Copy Markdown

Summary

  • Align glob path validation with grep: missing paths return Error: … not found instead of the misleading is not a directory.
  • Add regression tests for nonexistent and file paths.

Problem

When the model passes a bad directory to glob, the current message suggests a type mismatch rather than a missing path. grep already distinguishes these cases.

Test plan

  • Added test_glob_nonexistent_path and test_glob_path_is_file
  • pytest tests/test_tools.py -q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant