fix: replace silent catch {} blocks with diagnostic logging#1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: replace silent catch {} blocks with diagnostic logging#1devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Audit all empty catch blocks across ProfileService, SessionService,
and UsageService. Replace bare catch {} with targeted error handling:
- Distinguish ENOENT (expected) from unexpected filesystem errors
- Log warnings via console.warn with [keyflow] prefix for debuggability
- Preserve existing fallback behavior (no behavioral change)
- Surface actionable context in ensureCurrentCodexLinked warning messages
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited all
catch {}blocks acrossProfileService,SessionService, andUsageService— 18 total — and replaced each with targeted error handling that logs diagnostic context viaconsole.warn("[keyflow] ...")while preserving existing fallback behavior.Key patterns applied:
ENOENT-aware catches: filesystem catches that are expected to hit "file not found" (lock files, config.toml, backup auth, session dirs) now only log on unexpected errors:
Applied in:
acquireLockstale-lock check,releaseLock,syncCurrentCodexFilesToProfileconfig.toml copy,pruneBackups,switchToAccountbackup,resolveUsageUrl,listFiles,scanLogFile.Unconditional logging for non-trivial failures: catches where any error is noteworthy now always log:
readStatechmod + corrupt-backup,isCodexLinkedSync,saveAuthTokenscodex-auth sync,resolveUsageSnapshottoken-refresh and email-extraction, session-log parse errors.Richer warning in
ensureCurrentCodexLinked: the outer catch now distinguishes ENOENT (returns generic "not logged in" message) from other failures (returnsCodex auth file could not be read: <message>) so callers/bridge/UI can surface actionable info instead of a misleading "not logged in."No behavioral changes beyond added logging and the improved
ensureCurrentCodexLinkedwarning message. All existing tests pass; typecheck clean.Link to Devin session: https://app.devin.ai/sessions/df1ba521fd0c45a5b0a581aa1686652a
Requested by: @hbui290