Skip to content

fix: replace silent catch {} blocks with diagnostic logging#1

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1783099680-improve-error-handling
Open

fix: replace silent catch {} blocks with diagnostic logging#1
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1783099680-improve-error-handling

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

Audited all catch {} blocks across ProfileService, SessionService, and UsageService — 18 total — and replaced each with targeted error handling that logs diagnostic context via console.warn("[keyflow] ...") while preserving existing fallback behavior.

Key patterns applied:

  • ENOENT-aware catches: filesystem catches that are expected to hit "file not found" (lock files, config.toml, backup auth, session dirs) now only log on unexpected errors:

    // before
    } catch {}
    // after
    } catch (err: any) {
      if (err?.code !== 'ENOENT') {
        console.warn(`[keyflow] Failed to ...: ${err?.message ?? err}`)
      }
    }

    Applied in: acquireLock stale-lock check, releaseLock, syncCurrentCodexFilesToProfile config.toml copy, pruneBackups, switchToAccount backup, resolveUsageUrl, listFiles, scanLogFile.

  • Unconditional logging for non-trivial failures: catches where any error is noteworthy now always log:

    • readState chmod + corrupt-backup, isCodexLinkedSync, saveAuthTokens codex-auth sync, resolveUsageSnapshot token-refresh and email-extraction, session-log parse errors.
  • Richer warning in ensureCurrentCodexLinked: the outer catch now distinguishes ENOENT (returns generic "not logged in" message) from other failures (returns Codex auth file could not be read: <message>) so callers/bridge/UI can surface actionable info instead of a misleading "not logged in."

No behavioral changes beyond added logging and the improved ensureCurrentCodexLinked warning message. All existing tests pass; typecheck clean.

Link to Devin session: https://app.devin.ai/sessions/df1ba521fd0c45a5b0a581aa1686652a
Requested by: @hbui290

Audit all empty catch blocks across ProfileService, SessionService,
and UsageService. Replace bare catch {} with targeted error handling:

- Distinguish ENOENT (expected) from unexpected filesystem errors
- Log warnings via console.warn with [keyflow] prefix for debuggability
- Preserve existing fallback behavior (no behavioral change)
- Surface actionable context in ensureCurrentCodexLinked warning messages

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@hbui290 hbui290 self-assigned this Jul 3, 2026
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant