fix: remove upstash dependency - #232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer
Kevin Rutledge
What changed?
Production login returned 500 because the auth callback calls the Upstash rate limiter before its try block, so an unreachable Upstash threw. This removes the Upstash dependency entirely (rate limiting, idempotency, and the Redis email-quota pre-split), which ends that outage class for a low-traffic internal tool. Overflow past Brevo's daily cap still queues through Brevo's own QUOTA_EXCEEDED response.
src/lib/rate-limit.ts,src/lib/idempotency.ts,src/lib/email-quota.tsand their call sitessrc/env.ts,package.jsondrop the two env vars, the production requirement, and both @upstash packagesHow to test
UPSTASH_REDIS_REST_URLat a dead host. On develop,POST /api/auth/callbackreturns 500. On this branch it returns 303.npm testandnpm run buildpass.Checklist