override origin for assets in banner e2e test to fix inconsistent test failure#16365
Open
AnastasiiaBalenko wants to merge 1 commit into
Open
override origin for assets in banner e2e test to fix inconsistent test failure#16365AnastasiiaBalenko wants to merge 1 commit into
AnastasiiaBalenko wants to merge 1 commit into
Conversation
juabara
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket link
What does this change?
This change guaranties that all assets come from the same origin in banner e2e test.
Why?
Sometimes banner e2e tests failed in CI/CD with errors in console, indicating that some of the chunks failed to be loaded from https://assets.guim.co.uk/ as can be seen on the screenshot. For successfully passed tests the same chunks were loaded from the same origin - https://localhost:9000. To prevent mixed-origin request of dynamic parts, configOverride frontendAssetsFullURL was used to explicitly point to correct origin.
Screenshots