harden Qwen3.8 nightly scheduling and output benchmark - #17
Draft
groxaxo wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Pacific/Aucklandby default)flockso manual and timer invocations cannot run concurrentlyReview findings fixed
The earlier benchmark could record a failed 32K case and still return success because only empty quality responses affected its exit code. That could incorrectly create the final done marker. The earlier wall-clock helper also did not explicitly protect elapsed-time calculations across Auckland daylight-saving transitions.
This PR changes completion to require all of:
No passing benchmark means no
benchmark.done.json.Nightly behavior
NIGHTLY_TIMEZONENIGHTLY_STOP_TIMEminusSTOP_GRACE_SECONDSNIGHTLY_STOP_TIMEValidation performed
The DST tests explicitly verify:
Target-machine validation before merge
This remains a draft until the Ubuntu/RTX 3090 host runs the installer and one real service/benchmark smoke test:
A full multi-night 27B quantization is not required to validate the schedule, but the assembled model benchmark must ultimately run on the target GPU before deleting the BF16 source or publishing the artifact.