fix(bigquery): implement robust wait loop for socket leak tests#17688
Draft
chalmerlowe wants to merge 1 commit into
Draft
fix(bigquery): implement robust wait loop for socket leak tests#17688chalmerlowe wants to merge 1 commit into
chalmerlowe wants to merge 1 commit into
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
This PR addresses flakiness in the
google-cloud-bigquerysystem tests that verify system resource cleanup (specifically open sockets).The Problem
Some system tests in
google-cloud-bigquerywere performing instantaneous assertions on the number of open sockets immediately after client closure or garbage collection. These assertions are fragile because underlying transport layers (like gRPC) and OS socket reclamation can occur asynchronously in background threads. This leads to intermittent failures (flakiness) especially under varied environmental loads or parallel execution.Solution
Refactored the fragile instantaneous checks in
test_client.pyandtest_magics.pyto use a Robust Wait-Loop pattern.google-cloud-pubsub.gc.collect()totest_magics.pyto align with best practices for resource verification tests.Note
Also includes some linting updates. Sorry.