Return null for unavailable compressed probe images - #457
Open
gregbenz wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gregbenz
marked this pull request as ready for review
August 18, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return null for unavailable compressed probe images
Summary
nullptrfrom the compressed base and gain-map getters when probing did not provide a payloadWhy
uhdr_dec_get_base_image()anduhdr_dec_get_gainmap_image()document that they returnnullptrwhen compressed image data is unavailable. HEIF/AVIF probing currently does not populate those compressed payloads, but the getters return a non-null descriptor withdata == nullptranddata_sz == 0.Callers following the documented pointer contract can therefore mistake an unavailable payload for valid compressed data and pass a null data pointer downstream.
This change returns
nullptrunless a non-empty compressed payload is present. JPEG probing behavior is unchanged.Testing
nullptrfor unavailable compressed payloads