Add RoPE embeddings#5481
Merged
Merged
Conversation
vfdev-5
reviewed
Jun 2, 2026
samanklesaria
force-pushed
the
rope
branch
3 times, most recently
from
June 3, 2026 18:04
319550d to
ea04909
Compare
vfdev-5
reviewed
Jun 16, 2026
samanklesaria
force-pushed
the
rope
branch
2 times, most recently
from
June 16, 2026 18:02
c7b1f41 to
efa289d
Compare
IvyZX
reviewed
Jun 16, 2026
Collaborator
|
@samanklesaria can you fix the merging conflict, thanks! |
Collaborator
|
@samanklesaria can you check mypy CI job if it is real? Thanks! |
IvyZX
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for RoPE. Specifically, a new function
dot_product_attention_with_ropecan be used as theattention_fnargument fornnx.MultiHeadAttention.