feat(mlnode): mount GET /api/v1/clock for dapi's ping job - #1586
Open
baychak wants to merge 1 commit into
Open
Conversation
204 + X-Server-Recv-Ns / X-Server-Send-Ns per the host-ping observability contract (gonka#1580). Without it dapi's mlnode probe falls back to /readyz + the Date header — second-granular, no clock divergence. Registered without check_service_conflicts so the probe answers in every service state, like /metrics. The join nginx proxies location / wholesale, so no allowlist change is needed for the path to reach mlnode.
baychak
force-pushed
the
feat/mlnode-clock-endpoint
branch
from
August 13, 2026 00:02
6b3f148 to
4ca78f4
Compare
a-kuprin
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
GET /api/v1/clockendpoint requested in #1580 ("Required follow-up: MLNode /api/v1/clock"), per the checklist in the proposal appendix.Two checklist items needed verification rather than code:
ProxyMiddlewarepasses/api/*straight throughlocation /wholesale (deploy/join/nginx.conf), so the path reaches mlnode unchanged and dapi's permanent-404 demotion cannot trigger