bump jsonld to 8.2.0 - #107
Open
lemoustachiste wants to merge 6 commits into
Open
Conversation
BREAKING CHANGE: The CheckResult object has been adapted to the jsonld.js response object
Contributor
Author
|
PS: I'll be out for the next 2 weeks+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a breaking change in the shape of
CheckResultas the shape of the response fromjsonldchanged. I also had to remove@types/jsonldas it does not seem to follow the latest APIs ofjsonld.It also introduces a half breaking change by adding a flag to check with
safemode on or not. I have tried to maintain the tests as they were as much as possible (because of the breaking change), so it means that some tests had to havesafemode on and others not.Finally eslint rules and packages seem to be outdated but I didn't go down that route at this point.