This repository was archived by the owner on May 10, 2026. It is now read-only.
fix: emit fleet sync push on commit and rename - #230
Merged
Conversation
ggmolly
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SC_12106fleet sync pushes after successful fleet commit and fleet rename operations.SC_12103andSC_12105ack result semantics while preventing push emission on failures.Changes
commanderFleetGroupInfomapper and reused it forSC_12101andSC_12106payload parity.pushFleetSyncto send oneGROUPINFO_P12update packet for fleet changes.FleetCommitandFleetRenameto send ack first, thenSC_12106on success only.SC_12101/SC_12106group parity.