ref(symcache): Improve conversion, turn location into proper tagged union - #1039
Open
Dav1dde wants to merge 1 commit into
Open
ref(symcache): Improve conversion, turn location into proper tagged union#1039Dav1dde wants to merge 1 commit into
Dav1dde wants to merge 1 commit into
Conversation
Dav1dde
force-pushed
the
dav1d/improve-conversions-tagged-unions
branch
from
August 5, 2026 12:31
2fa3780 to
c9378dd
Compare
Dav1dde
marked this pull request as ready for review
August 5, 2026 12:34
Dav1dde
force-pushed
the
dav1d/improve-conversions-tagged-unions
branch
from
August 5, 2026 12:37
c9378dd to
4527ba4
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves conversions from debuginfo types to raw types in symcaches:
convert.rs)There is also a breaking change in here, the removal of
PartialEqandEqfromSymCacheandSourceLocation. Comparing a sym cache is not cheap, it is implemented by comparing all individually stored types. It is equivalent to running amemcmpon the entire data region, which would be more efficient than comparing all individual types.If this needs to come back, we should either assign a uuid for each symcache or really do a memcmp.