Skip to content

test(django): Remove dead code and stale markers from the Django test suite #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 4 commits into from
Aug 12, 2026
Merged

test(django): Remove dead code and stale markers from the Django test suite #7156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
551ac55
test(django): Remove stale xfail marker from test_read_request
ericapisani Aug 6, 2026
c48f5ba
test(django): Remove dead rest_hello view and URL from test app
ericapisani Aug 6, 2026
e5a5204
test(django): Remove spurious django_db marker from test_response_trace
ericapisani Aug 7, 2026
7b3b911
test(django): Remove unused fixture args from 7 test signatures
ericapisani Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/integrations/django/myapp/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ def path(path, *args, **kwargs):
name="rest_framework_read_body_and_exc",
)
)
urlpatterns.append(path("rest-hello", views.rest_hello, name="rest_hello"))
urlpatterns.append(
path(
"rest-authenticated-hello",
Expand Down
4 changes: 0 additions & 4 deletions tests/integrations/django/myapp/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ def rest_framework_read_body_and_exc(request):
request.data
1 / 0

@api_view(["GET"])
def rest_hello(request):
return HttpResponse("ok")

@api_view(["GET"])
def rest_permission_denied_exc(request):
raise PermissionDenied("bye")
Expand Down
3 changes: 0 additions & 3 deletions tests/integrations/django/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,6 @@ def test_user_captured(
def test_materialized_user_captured(
sentry_init,
client,
capture_events,
capture_items,
):
sentry_init(
Expand Down Expand Up @@ -815,7 +814,6 @@ def test_sql_dict_query_params(


@pytest.mark.forked
@pytest_mark_django_db_decorator()
@pytest.mark.parametrize("span_streaming", [True, False])
def test_response_trace(
sentry_init,
Expand Down Expand Up @@ -1369,7 +1367,6 @@ def test_request_body(
assert "" not in event


@pytest.mark.xfail
@pytest.mark.parametrize("span_streaming", [True, False])
def test_read_request(
sentry_init,
Expand Down
1 change: 0 additions & 1 deletion tests/integrations/django/test_db_query_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,6 @@ def test_db_span_origin_execute(
@pytest.mark.parametrize("span_streaming", [True, False])
def test_db_span_origin_executemany(
sentry_init,
client,
capture_events,
capture_items,
span_streaming,
Expand Down
5 changes: 0 additions & 5 deletions tests/integrations/django/test_db_transactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,6 @@ def test_db_no_autocommit_execute(
@pytest.mark.parametrize("span_streaming", [True, False])
def test_db_no_autocommit_executemany(
sentry_init,
client,
capture_events,
capture_items,
span_streaming,
Expand Down Expand Up @@ -900,7 +899,6 @@ def test_db_no_autocommit_rollback_execute(
@pytest.mark.parametrize("span_streaming", [True, False])
def test_db_no_autocommit_rollback_executemany(
sentry_init,
client,
capture_events,
capture_items,
span_streaming,
Expand Down Expand Up @@ -1181,7 +1179,6 @@ def test_db_atomic_execute(
@pytest.mark.parametrize("span_streaming", [True, False])
def test_db_atomic_executemany(
sentry_init,
client,
capture_events,
capture_items,
span_streaming,
Expand Down Expand Up @@ -1457,7 +1454,6 @@ def test_db_atomic_rollback_execute(
@pytest.mark.parametrize("span_streaming", [True, False])
def test_db_atomic_rollback_executemany(
sentry_init,
client,
capture_events,
capture_items,
span_streaming,
Expand Down Expand Up @@ -1737,7 +1733,6 @@ def test_db_atomic_execute_exception(
@pytest.mark.parametrize("span_streaming", [True, False])
def test_db_atomic_executemany_exception(
sentry_init,
client,
capture_events,
capture_items,
span_streaming,
Expand Down
Loading