fix(attributes): Add status backfill to deprecated attributes with renamed replacements - #571
Open
Lms24 wants to merge 3 commits into
Open
fix(attributes): Add status backfill to deprecated attributes with renamed replacements#571Lms24 wants to merge 3 commits into
backfill to deprecated attributes with renamed replacements#571Lms24 wants to merge 3 commits into
Conversation
…renamed replacements
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
August 13, 2026 21:26
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
New Features ✨Attributes
Op
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Lms24
commented
Aug 13, 2026
| "alias": ["network.local.address", "net.host.ip"], | ||
| "deprecation": { | ||
| "_status": null, | ||
| "_status": "backfill", |
Member
Author
There was a problem hiding this comment.
given the example, the deprecation just being a rename doesn't seem to be 100% straight forward but OTEL also lists that network.local.address may hold /var/my.sock. I added it as an example in our definition of network.local.address
nsdeschenes
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the deprecation status
"backfill"to a bunch of attributes that were straight renames but for unknown reasons had statusnull. This means, these attributes are now added to the deprecation chains on theATTRIBUTE_METADATAobject to allow for deprecation-safe attribute accesses.closes #570
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated: