ref(attributes): Disambiguate http.route and url.template attributes - #521
Merged
Conversation
|
Current version of PR was reviewed by /review-bugbot on Jul 23, 13:21 GMT+2. It flagged 1 finding. Show 1 finding1. Invalid PR number zero in changelog
The Bugbot on commit |
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧Attribute
Attributes
Deps
Other
🤖 This preview updates automatically when you update the PR. |
http.route and url.full attributeshttp.route and url.template attributes
Lms24
marked this pull request as ready for review
July 23, 2026 12:03
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
July 23, 2026 12:03
cleptric
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
http.routeandurl.templatealiased each other. I think we should avoid treating them fully equally, since they shouldn't be used interchangeably and neither is one of them deprecated (both still active in OTel, althoughurl.templatestill has status "development").OTel specifies the following:
I'd recommend, we also additionally use
url.templateon client-side router spans (pageloads and navigations).So this PR: