Skip to content

ref(attributes): Disambiguate http.route and url.template attributes - #521

Merged
Lms24 merged 4 commits into
mainfrom
lms/ref-disambiguate-http.route-url.template
Jul 28, 2026
Merged

ref(attributes): Disambiguate http.route and url.template attributes#521
Lms24 merged 4 commits into
mainfrom
lms/ref-disambiguate-http.route-url.template

Conversation

@Lms24

@Lms24 Lms24 commented Jul 23, 2026

Copy link
Copy Markdown
Member

Previously, http.route and url.template aliased each other. I think we should avoid treating them fully equally, since they shouldn't be used interchangeably and neither is one of them deprecated (both still active in OTel, although url.template still has status "development").

OTel specifies the following:

I'd recommend, we also additionally use url.template on client-side router spans (pageloads and navigations).

So this PR:

  • removes the alias between the two attributes
  • adds additional context when to (not) use which one

@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown

Current version of PR was reviewed by /review-bugbot on Jul 23, 13:21 GMT+2. It flagged 1 finding.

Show 1 finding

1. Invalid PR number zero in changelog

model/attributes/http/http__route.json:18 · High Severity

The next changelog entry lists prs: [505, 0], but 0 is not a valid GitHub pull request number. The sibling url.template change correctly uses only [505].

Bugbot on commit 6708d39 is skipped.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add django.middleware_name (deprecated) in favor of middleware.name by alexander-alderman-webb in #520
  • Add starlite.middleware_name (deprecated) in favor of middleware.name by alexander-alderman-webb in #519
  • Add aws.request.url (deprecated) in favor of url.full by sentrivana in #488
  • Add subprocess.pid (deprecated) in favor of process.pid by sentrivana in #487
  • Add litestar.middleware_name (deprecated) in favor of middleware.name by sentrivana in #486
  • Add starlette.middleware_name (deprecated) in favor of middleware.name by sentrivana in #485
  • Add redis.key (deprecated) in favor of db.redis.key by sentrivana in #484
  • Add db.mongodb.collection (deprecated) in favor of db.collection.name by sentrivana in #483
  • Add Kafka messaging attributes by chargome in #474
  • Deprecate rpc.grpc.status_code in favor of rpc.response.status_code by lucas-zimerman in #494
  • Add deprecated messaging.destination_kind by andreiborza in #509
  • Add sentry.segment.name.source attribute by Lms24 in #466
  • Add attribute transformations by constantinius in #465
  • Add stable app vitals attributes by buenaflor in #493
  • Deprecate sentry.frames.* attributes by buenaflor in #500
  • Add missing AI legacy aliases from Relay SpanData by vgrozdanic in #498

Other

  • (conventions) Support multiple examples by Lms24 in #505
  • (descriptions) Add http.route description template for http.server span description inference by Lms24 in #518

Internal Changes 🔧

Attribute

  • Add more examples for valid sentry.kind values by Lms24 in #517
  • Improve db.statement example and add deprecation reason by Lms24 in #501

Attributes

  • Disambiguate http.route and url.template attributes by Lms24 in #521
  • Improve description of sentry.segment.name.source by Lms24 in #511
  • Deprecate sentry.span.source and change backfill status of sentry.source by Lms24 in #510

Deps

  • Bump dompurify from 3.4.11 to 3.4.12 by dependabot in #525
  • Bump fast-uri from 3.1.2 to 3.1.4 by dependabot in #526
  • Bump svgo from 4.0.1 to 4.0.2 by dependabot in #524
  • Bump js-yaml from 4.2.0 to 4.3.0 by dependabot in #516
  • Bump astro from 6.4.7 to 7.1.0 in /docs by dependabot in #514

Other

  • (attrs) Backport attributes and normalizations from Relay by Dav1dde in #497
  • (codeowners) Assign telemetry-experience to gen_ai/ai attributes by vgrozdanic in #506
  • (deps-dev) Bump tar from 7.5.16 to 7.5.19 by dependabot in #515
  • (release) Show version in workflow run title by constantinius in #504

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 changed the title ref(attributes): Disambiguate http.route and url.full attributes ref(attributes): Disambiguate http.route and url.template attributes Jul 23, 2026
@Lms24
Lms24 marked this pull request as ready for review July 23, 2026 12:03
@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners July 23, 2026 12:03
@Lms24 Lms24 self-assigned this Jul 23, 2026
@Lms24
Lms24 enabled auto-merge (squash) July 28, 2026 16:06
@Lms24
Lms24 merged commit b81eba7 into main Jul 28, 2026
16 checks passed
@Lms24
Lms24 deleted the lms/ref-disambiguate-http.route-url.template branch July 28, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants