feat: add getaddednodeinfo rpc#1114
Open
jaoleal wants to merge 5 commits into
Open
Conversation
jaoleal
added
the
rpc
jaoleal
commented
Jun 3, 2026
| let ip = addr_str | ||
| .parse::<IpAddr>() | ||
| .map_err(|_| JsonRpcError::InvalidAddress)?; | ||
| (ip, 8333) |
Member
Author
|
Ill rebase after #1114 (comment) |
jaoleal
marked this pull request as draft
June 3, 2026 17:59
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
2 times, most recently
from
June 9, 2026 16:31
a9319c4 to
71aadb4
Compare
Member
Author
|
Rebased
|
jaoleal
marked this pull request as ready for review
June 9, 2026 16:40
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
2 times, most recently
from
June 15, 2026 19:11
9c7f455 to
8b3d462
Compare
Member
Author
|
@Davidson-Souza done |
Member
|
Needs rebase. |
Comment on lines
+1
to
+3
| # `getaddednodeinfo` | ||
|
|
||
| Return information about nodes that were manually added. |
Contributor
There was a problem hiding this comment.
nit: docs in a doc commit
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
from
June 16, 2026 12:35
8b3d462 to
e91e5a7
Compare
Member
Author
|
Rebased and made a commit only for the md documentation |
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
from
June 18, 2026 17:23
e91e5a7 to
0b97c15
Compare
Member
Author
|
Rebased and fixed the problem with the docs |
moisesPompilio
suggested changes
Jun 19, 2026
|
|
||
|
|
||
| @pytest.mark.rpc | ||
| def test_get_added_node_info_empty(florestad_node): |
Collaborator
There was a problem hiding this comment.
In this case, keeping the tests separated makes the test suite slower, since each test has to start a new node instance, and the startup time is greater than the time spent running the actual test logic. I think it's better to group them into a single test.
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
from
June 22, 2026 17:48
0b97c15 to
1ce4316
Compare
moisesPompilio
suggested changes
Jun 23, 2026
| """ | ||
| Passing an invalid address as the node filter should return an error. | ||
| """ | ||
| resp = make_request( |
Collaborator
There was a problem hiding this comment.
I think using rpc.noraise_request directly is cleaner than using make_request, since it makes it more explicit where the request is being performed.
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
2 times, most recently
from
June 24, 2026 15:00
daab2d5 to
392bcd4
Compare
Member
Author
|
typo solved on 392bcd4 |
moisesPompilio
suggested changes
Jun 29, 2026
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
2 times, most recently
from
July 2, 2026 20:55
71bc304 to
fde9587
Compare
Member
Author
|
Done @moisesPompilio |
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
from
July 9, 2026 16:10
fde9587 to
6c5fc2c
Compare
Member
Author
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
from
July 9, 2026 16:13
6c5fc2c to
ccf5adc
Compare
Member
Author
|
CI failed |
Add the wire-layer plumbing for the getaddednodeinfo RPC: - AddedNodeInfo struct in node_interface - UserRequest::GetAddedNodeInfo and NodeResponse::GetAddedNodeInfo variants - get_added_node_info() method on NodeInterface - handle_get_added_node_info() implementation in peer_man - Match arm in perform_user_request()
Register the getaddednodeinfo RPC endpoint in the JSON-RPC server: - Add get_added_node_info() handler in network.rs - Register "getaddednodeinfo" route in server.rs
Add getaddednodeinfo to the FlorestaRPC trait and its blanket implementation for JSON-RPC clients. Wire the new method into the floresta-cli binary as a subcommand.
Add Python integration test verifying getaddednodeinfo returns correct information about manually added nodes, and add the get_added_node_info() wrapper to the test framework.
jaoleal
force-pushed
the
rpc/getaddednodeinfo
branch
from
July 21, 2026 15:06
ccf5adc to
01a48ee
Compare
Member
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
add get addednodeinfo rpc that returns info about the nodes that were manually added and their addresses and wheter theyre connected.
Split of #916
How to verify the changes you have done?
I tried to cover the basic cases so:
Read & Run integration tests.