Fix OOM crash when importing large/corrupted .eap-config files - #180
Open
SanderVeer wants to merge 1 commit into
Open
Fix OOM crash when importing large/corrupted .eap-config files#180SanderVeer wants to merge 1 commit into
SanderVeer wants to merge 1 commit into
Conversation
buildDeepLink() read the file with the stdlib InputStream.readBytes(), which pre-sizes its ByteArrayOutputStream using available(). For some content:// URIs that value is unreliable and can report a huge bogus size, causing an immediate multi-hundred-MB allocation attempt and an OutOfMemoryError (Crashlytics issue 375883fdcbf164622a8a6870d7988eba, top crash of the last 30 days). Switch to the existing extensions.InputStream.readBytes(), which reads in fixed 4KB chunks instead of trusting available(). It was added alongside this same file-import feature but was never actually wired up, so the file was silently using the stdlib version all along.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to the existing extensions.InputStream.readBytes(), which reads in fixed 4KB chunks instead of trusting available(). It was added alongside this same file-import feature but was never actually wired up, so the file was silently using the stdlib version all along causing crashes when importing .eap-config files with large logos included. Removing .close() as this was already handled by the extension function.