chore(deps): override uuid to clear the runtime Dependabot alert - #101
Merged
Conversation
The shipped @wordpress/components pulled uuid 9.0.1 (and sockjs pulled 8.3.2), both under the patched 11.1.1. Pin uuid via overrides so the production bundle carries the patched version. Result: production audit (npm audit --omit=dev) is now 0 vulnerabilities — nothing vulnerable ships in dist/. Verified: typecheck + build pass with the ESM-only uuid 11. The remaining Dependabot alerts (minimatch, markdown-it, webpack-dev-server) are build-only devDependencies hard-pinned by @wordpress/scripts' own transitive set; they never ship and are tracked for dismissal rather than risky force-overrides.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a new ChangesDependency Override Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #100. After that merged, 7 Dependabot alerts remained. This clears the only one that ships to users.
uuid (runtime — fixed here)
@wordpress/componentspulleduuid@9.0.1andsockjspulled8.3.2, both below the patched11.1.1. Added"uuid": "^11.1.1"tooverrides.npm audit --omit=dev→ 0 vulnerabilities (nothing vulnerable indist/).npm run typecheck✅ andnpm run build✅ with the ESM-only uuid 11.The other 6 alerts (dev-only — recommend dismiss, not override)
minimatch,markdown-it,webpack-dev-server(×4) are build tooling hard-pinned by@wordpress/scripts@32.5.1itself (webpack-dev-server ^4.15.1;markdown-it@12.3.2exact-pinned bymarkdownlint@0.25.1). They never ship in the plugin. Force-overriding them fights @wordpress/scripts' tested set and risks breakingnpm start/ readme-lint. Best handled by dismissing the alerts as "only in dev dependencies / vulnerable code not used in production," or waiting for an upstream @wordpress/scripts bump.Summary by CodeRabbit