Skip Qt workflow tests when PySide6 is not installed in core CI - #14
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job test (ubuntu, py3.11)
Skip Qt workflow tests when PySide6 is not installed in core CI
Aug 3, 2026
geohang
marked this pull request as ready for review
August 3, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test (ubuntu, py3.11)workflow was failing during pytest collection becausetests/test_workflow_process.pyimportedPySide6unconditionally, while the core test job does not install the desktop Qt dependency. This change scopes the Qt dependency to the tests that actually need it so the rest of the workflow-process coverage still runs in headless CI.Root cause
tests/test_workflow_process.pyimportedQProcessandProcessWorkflowWorkerat module load time.PySide6is absent by design, so collection aborted before any tests in the module could run.Change
pytest.importorskip("PySide6")inside that helper so GUI-specific tests skip cleanly when the desktop extra is not installed.Effect
test_workflow_process.pycontinue to execute in the core CI environment.ProcessWorkflowWorkertests become conditional onPySide6, matching the package's optional dependency model.