feat(js): enable OTel logs feature (remove GENKIT_OTEL_ENABLE_LOGS flag) - #6069
Open
shrutip90 wants to merge 2 commits into
Open
feat(js): enable OTel logs feature (remove GENKIT_OTEL_ENABLE_LOGS flag)#6069shrutip90 wants to merge 2 commits into
shrutip90 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the environment variable check GENKIT_OTEL_ENABLE_LOGS to enable OpenTelemetry logs by default. A review comment points out that unconditionally overwriting nodeOtelConfig.logRecordProcessor will discard any user-configured custom log record processors, and suggests merging them using a composite processor wrapper instead.
… in their TelemetryConfig
pavelgj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the GENKIT_OTEL_ENABLE_LOGS feature flag. Also fixed a bug where we were unconditionally overwriting nodeOtelConfig.logRecordProcessor and losing any custom log record processors configured by the user in telemetryConfig.
Checklist (if applicable):