Capture this explicitly in the InterfaceAPI find callback (backport #1699) - #1701
Merged
Conversation
19 tasks
Assisted-by: Claude Opus 5 Signed-off-by: Carlos Agüero <caguero@honurobotics.com> (cherry picked from commit 36536d8)
caguero
force-pushed
the
mergify/bp/sdf16/pr-1699
branch
from
August 13, 2026 18:19
efbdfe1 to
e7498ab
Compare
scpeters
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of gazebosim/gz-cmake#580
Summary
[=]implicitly capturedthis, which is deprecated in C++20. The lambda only usesthis->modelDir, so the capture is now explicit. No behavior change, and it is valid C++17, so it can land before any standard bump.Before:
Backport Policy
Checklist
codecheckpassed (See contributing)Assisted-by: Claude Opus 5
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #1699 done by [Mergify](https://mergify.com).