Skip to content

Capture this explicitly in the InterfaceAPI find callback (backport #1699) - #1701

Merged
scpeters merged 1 commit into
sdf16from
mergify/bp/sdf16/pr-1699
Aug 13, 2026
Merged

Capture this explicitly in the InterfaceAPI find callback (backport #1699)#1701
scpeters merged 1 commit into
sdf16from
mergify/bp/sdf16/pr-1699

Conversation

@mergify

@mergify mergify Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🦟 Bug fix

Part of gazebosim/gz-cmake#580

Summary

[=] implicitly captured this, which is deprecated in C++20. The lambda only uses this->modelDir, so the capture is now explicit. No behavior change, and it is valid C++17, so it can land before any standard bump.

Before:

test/integration/interface_api.cc:151:9: warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]

Backport Policy

  • This is safe to backport to the following versions:
    • Jetty
    • Ionic
    • Harmonic
    • Fortress
  • This should not be backported
  • I am not sure
  • Other (fill in yourself)

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Assisted-by" to your commits. (See this policy for more info.)

Assisted-by: Claude Opus 5

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #1699 done by [Mergify](https://mergify.com).

Assisted-by: Claude Opus 5
Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
(cherry picked from commit 36536d8)
@caguero
caguero force-pushed the mergify/bp/sdf16/pr-1699 branch from efbdfe1 to e7498ab Compare August 13, 2026 18:19
@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Aug 13, 2026
@scpeters
scpeters enabled auto-merge (rebase) August 13, 2026 18:39
@scpeters
scpeters merged commit 9a26f90 into sdf16 Aug 13, 2026
15 checks passed
@scpeters
scpeters deleted the mergify/bp/sdf16/pr-1699 branch August 13, 2026 19:23
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants