Re-enable npm provenance (merge after repo is public)#12
Open
nrodd wants to merge 1 commit into
Open
Conversation
Restores the provenance publishing that was dropped in the 0.1.6 fix: adds --provenance back to the release workflow and provenance: true to publishConfig. DO NOT MERGE until fullstorydev/subtext-wizard is made public. npm rejects provenance attestations from private source repos (E422 'Unsupported ... source repository visibility: private'), which is why provenance is currently off. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b3c64e9. Configure here.
| "publishConfig": { | ||
| "access": "public" | ||
| "access": "public", | ||
| "provenance": true |
There was a problem hiding this comment.
Provenance blocks local npm publish
Medium Severity
Setting publishConfig.provenance to true makes every npm publish attempt Sigstore provenance, which needs a CI OIDC provider. Local publishes (including with the existing prepublishOnly script) fail with automatic provenance errors even after the GitHub repo is public. CI can use --provenance alone.
Reviewed by Cursor Bugbot for commit b3c64e9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Re-enables npm provenance publishing, which is currently disabled:
--provenanceback to theReleaseworkflow's publish step"provenance": trueback topublishConfiginpackage.jsonMerge this only after
fullstorydev/subtext-wizardis made public.npm rejects provenance attestations from private source repos:
Provenance was originally dropped in 059d114 for exactly this reason. It got
accidentally re-added during the security-review pass (7d50bed), which broke
the 0.1.6 publish (E422). The fix (
36a5b2e) removed it again. This PR is thedeferred re-enable for when the repo goes public.
🤖 Generated with Claude Code
Note
Low Risk
Release-only config; risk is operational (failed publish if merged while the repo is still private), not runtime or security logic changes.
Overview
Re-enables npm provenance on publish so releases can ship Sigstore attestations once the GitHub source repo is public.
The Release workflow publish step now runs
npm publish --access public --provenance(with comments noting E422 if the repo is still private).package.jsonadds"provenance": trueunderpublishConfigalongside existing public access.Do not merge until the repository is public — the same visibility check that blocked 0.1.6 will fail CI/release publishes from a private repo.
Reviewed by Cursor Bugbot for commit b3c64e9. Bugbot is set up for automated code reviews on this repo. Configure here.