fix(fetch): block pending-deleted item processing#3602
Open
wizardengineer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScheduledDeletionwhen anitem_deletedpending event is created.Context
Refs #3575.
The projected conversation view already hides items with pending
item_deletedevents, but the fetch/decrypt worker reads rawitemsrows. This patch binds the pending deletion to raw processability and to the final DB completion write, so a hidden deleted item cannot continue through download/decrypt and store plaintext after the UI action.Test plan
cd app pnpm run lintObserved result:
Observed result:
Observed result:
Observed result:
cd app pnpm run build:linuxObserved result:
Observed result: no output.
Notes
I ran the app checks locally with Node 24.16.0 to match the app workflow's Node 24 setup.
I did not run
pnpm server-testlocally because the shared SecureDrop server-test slot was reserved for another acceptance run. The added regression coverage exercises the production database and worker completion paths without starting the server harness.Checklist
This change accounts for:
main)