fix(fetch): guard item status transitions#3586
Open
wizardengineer wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Refs #3567.
This extends the deletion guards added in #3440 to every later status write.
Test plan
Observed: Prettier reported the file uses project style, ESLint exited 0, and
typecheck:nodeexited 0.Observed: the custom app Semgrep rules scanned
database/index.tswith 0findings, and the diff check passed.
Not completed locally: this macOS environment is running Node v26.0.0, and
pnpm installfailed during postinstall while trying to download thebetter-sqlite3node-v147 darwin-arm64 artifact, which returned 404. Thedatabase-backed test command therefore failed before assertions at the missing
native binding load.
Not run locally:
make lintrequires Poetry, which is not installed here; thefull app lint/test/build commands are left for CI because local dependency
postinstall could not complete under Node v26.
Notes
The CI fix removes the dynamic SQL predicate interpolation that tripped
app..semgrep.better-sqlite3-ban-dynamic-content; the same allowed enum valuesare now spelled directly in the prepared statements. Qubes and packaged Linux
builds were not run locally.
Checklist
This change accounts for:
main)