Pathing docs for yasen - #194
Open
arinemet wants to merge 5 commits into
Open
Conversation
Signed-off-by: Ari <nanoticity@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the src/pathing documentation to describe the pathing stack (grid BFS, spline math, and high-level path-following steps) in more detail.
Changes:
- Added BFS pseudocode and implementation notes.
- Added B-spline math sections (knot vector, basis function, finite differences, evaluation/derivatives).
- Added a brief outline of the path-following approach.
Suppressed comments (3)
src/pathing/README.md:57
- This nested bullet should be properly capitalized and refer to BFS consistently.
- this is coming from bfs
src/pathing/README.md:71
- Typo: "piont" → "point".
- $P_i$ is control piont at index $i$
src/pathing/README.md:77
- Header typo: "positioin" → "position".
### Evaluate positioin
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ari <66433127+arinemet@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (3)
src/pathing/README.md:71
- Spelling typo in documentation: "control piont" should be "control point".
- $P_i$ is control piont at index $i$
src/pathing/README.md:57
- This sub-bullet is informal and unclear ("this is coming from bfs"). Consider folding it into the main definition with consistent capitalization/acronyms.
- $P_i$ is control point $i$
- this is coming from bfs
src/pathing/README.md:77
- Section heading has a spelling typo: "positioin" should be "position".
### Evaluate positioin
Signed-off-by: Ari <nanoticity@gmail.com>
# Conflicts: # src/pathing/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.