fix: upgrade base image and CI to Node 24 (Active LTS) - #117
Merged
Conversation
Node 22 entered Maintenance LTS in Oct 2025; Node 24 is now the Active LTS line. s3proxy only requires Node >=22.13, so 24 satisfies it. - Dockerfile: base image node:22-alpine -> node:24-alpine, repinned to the current multi-arch (amd64+arm64) manifest-list digest - CI: node-version 22 -> 24 across lint/test/docker jobs - package.json engines floor 22.13.0 -> 24.0.0 (lockfile synced) - README: image-layout note updated to Node 24
gmoon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Node 22 ("Jod") entered Maintenance LTS in October 2025; Node 24 is now the Active LTS line. The image was on 22 only by inertia — it was pinned there and nothing moved it.
s3proxyrequires Node>=22.13, which 24 satisfies, so there's no dependency blocker to moving up.Changes
Dockerfile— base imagenode:22-alpine→node:24-alpine, repinned to the current multi-arch manifest-list digest (sha256:a0b9bf06…). Verified the digest resolves to a manifest list containinglinux/amd64+linux/arm64(the two platforms this image publishes). Comment updated..github/workflows/ci.yml—node-version: 22→24across the lint, test, and docker jobs.package.json— engines floor>=22.13.0→>=24.0.0, with the root entry inpackage-lock.jsonsynced to match. The@forkzero/s3-website-test-kitdependency's own>=22.13.0engines entry is left untouched.README.md— image-layout note updated to "Alpine + Node 24".Dependabot
No change needed.
.github/dependabot.ymlhas no version pins or ignore rules for the docker ecosystem — the docker updater follows whatever tag is in theFROMline. Now that it reads24-alpine, Dependabot tracks the 24 line automatically (digest bumps for24-alpine, and it will propose25-alpinewhen that ships).Verification
The new digest was confirmed to be a valid multi-arch (amd64 + arm64) manifest list. The image build and lint were not run in this environment (no Docker daemon, dependencies not installed) — CI will exercise the full build, container smoke test, and conformance gate on Node 24.
🤖 Generated with Claude Code
Generated by Claude Code