feat(regex): make callback mutations transactional - #974
Merged
Conversation
Snapshot ordinary callback-visible scalar, array, and hash state for each matcher attempt. Restore it when the overall match fails or a callback throws, while preserving Perl's committed mutations when another alternative succeeds. Hide internal callback IDs from regex stringification without breaking callback remapping for embedded patterns. Add standard-Perl-valid regression coverage and update the Phase 36 delivery plan with the verified 42/42 rxcode baseline. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
perl5_t/t/re/rxcode.t: 42/42 (previously 39/42)perl5_t/t/re/reg_eval_scope.t: 22/49, unchanged and documented as the next Stage 36.4 sliceValidation
make— PASScallback_mutation_rollback.t— 9/9callback_mutation_rollback.t— 9/9 eachcallback_stringification.t— 2/2callback_stringification.t— 2/2 eachrxcode.t42/42;reg_eval_scope.t22/49; no timeout or incomplete file