Fix HTML parser tooling for TagRescue - #941
Merged
Merged
Conversation
Route unhandled HTML::Parser events through the configured default handler, bracket parse cycles with document events, and preserve undef tag names for non-tag events. This restores Template::Plugin::TagRescue filter output without distribution-specific preferences. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <158243242+openai-codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTML::Parserevents through the configured default handlerstart_documentandend_documentaround parse cyclesThis fixes
Template::Plugin::TagRescueat the shared Java-backed HTML parser layer, without a distribution preference.Requested module results
Template::Plugin::TagRescue: passes after the fix (18 tests)Cikl: passes its normal jcpan workflow; its release contains no runnable top-level test filesPython: ignored because CPAN resolves it topyperl-1.0.3, which has no Perl build file and fails identically under system PerlData::Dumper::EasyOO: ignored because its upstream suite fails under system Perl with the same re-import/POD-coverage failuresGuiBuilder: ignored because its Tk dependency fails to configure under system Perl on this platform, after which GuiBuilder cannot loadVerification
prove src/test/resources/unit/html_parser_default_handler.twith system Perlmake./jcpan -t Template::Plugin::TagRescue./jcpan --strict-dependency-tests -t Template::Plugin::TagRescue./jcpan -t CiklThe strict Cikl dependency audit also exercised dependency suites. Its remaining dependency failures reproduce under system Perl (for example Net::DNS's distribution test cannot locate its adjacent
t/TestToolkit.pm) and are outside this PerlOnJava fix.Generated with Codex