fix(macos): Handle @rpath references in dylib bundling script - #468
Open
dodidev wants to merge 1 commit into
Open
fix(macos): Handle @rpath references in dylib bundling script#468dodidev wants to merge 1 commit into
dodidev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix macOS runtime crash caused by missing transitive
@rpathdependencies.The
copy-macos-dylib.shscript previously only copied dynamic libraries with absolute Homebrew paths. This caused runtime crashes (e.g.,dyld: library not loaded) because it missed transitive dependencies that rely on relative@rpathreferences—such aslibwebp.7.dylibfailing to loadlibsharpyuv.0.dylib.This PR enhances the dependency resolution inside
scripts/copy-macos-dylib.shto recursively discover, copy, and link both absolute and@rpathHomebrew libraries.Key Changes
@rpathExtraction: Usesotool -Lto scan binaries and discover all nested@rpathdependencies.@rpathlibraries within Homebrew, copies them to the app bundle, and updates their install names.@rpathlibrary cannot be found in the expected Homebrew path to simplify troubleshooting.Evidence / Error Log