Check that treatment_start_time and treatment_end_time are integers before proceeding with GeoLiftMultiCell.#126
Open
lukasvermeer wants to merge 2 commits into
Conversation
…efore proceeding with GeoLiftMultiCell.
…me and treatment_end_time.
facebook-github-bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this change is trivial, but I just lost two hours because I used
treatment_start_time = difftime("2022-08-14","2020-10-26")as input forGeoLiftMultiCelland it only complained about this being incorrect after it had completed the model selection step. I hope this addition will save someone else a few hours of waiting.