Skip to content

acctonbmc: Add WEDGE800{B|C}NHP support to CIT - #275

Open
louis-nexthop wants to merge 4 commits into
facebook:heliumfrom
nexthop-ai:fix-acctonbmc-cit-failures
Open

acctonbmc: Add WEDGE800{B|C}NHP support to CIT#275
louis-nexthop wants to merge 4 commits into
facebook:heliumfrom
nexthop-ai:fix-acctonbmc-cit-failures

Conversation

@louis-nexthop

@louis-nexthop louis-nexthop commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

  1. Include more mac patterns: E8:E4:9D:... for Nexthop.
  2. Include more product names: WEDGE800BNHP and WEDGE800CNHP.
  3. Allow tests to run on WEDGE800BNHP and WEDGE800CNHP.

Motivation

  • To make tests run on WEDGE800BNHP and WEDGE800CNHP.
  • To fix test failures like below:
test_bmc_mac_oui (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac_oui) ... FAIL

======================================================================
FAIL: test_bmc_mac_oui (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac_oui)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/run/tests2/common/base_bmc_mac_test.py", line 115, in test_bmc_mac_oui
    self.assertTrue(
    ~~~~~~~~~~~~~~~^
        found,
        ^^^^^^
        " the mac address not contain in pattern list \n"
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        " {} not match in {}".format(mac, " ".join(self.mac_pattern)),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: None is not true :  the mac address not contain in pattern list
 e8:e4:9d:17:29:c5
 not match in (ac\:81\:b5\:..\:..\:..)

----------------------------------------------------------------------
======================================================================
FAIL: test_product_name (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_name)
Tests if the platform defined product name is present
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/run/tests2/common/base_eeprom_test.py", line 107, in test_product_name
    self.assertTrue(
    ~~~~~~~~~~~~~~~^
        found, "Product name {} not in set {}".format(name, self.product_name)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: False is not true : Product name wedge800bnhp not in set ['MINIPACK3N', 'MINIPACK3BA']

----------------------------------------------------------------------

Test Plan

All tests pass consistently:

root@bmc:/run/tests2# python cit_runner.py --platform acctonbmc --run-test tests.acctonbmc.test_bmc_mac
test_bmc_mac (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac) ... ok
test_bmc_mac_oui (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac_oui) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.890s

OK
root@bmc-oob:/run/tests2# python cit_runner.py --run-test tests.acctonbmc.test_eeprom
test_asset_tag (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_asset_tag) ... ok
test_bmc_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_bmc_mac) ... ok
test_crc_matched (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_crc_matched)
Tests that the EEPROM CRC16 checksum matches. ... ok
test_extended_mac_base (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_extended_mac_base) ... ok
test_local_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_local_mac) ... ok
test_location_on_fabric (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_location_on_fabric) ... ok
test_odm_pcb (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_odm_pcb) ... ok
test_product_name (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_name)
Tests if the platform defined product name is present ... ok
test_product_part_number (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_part_number) ... ok
test_product_serial_number (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_serial_number) ... ok
test_switch_asic_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_switch_asic_mac) ... ok
test_system_manufacturer (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_system_manufacturer) ... ok
test_version (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_version) ... ok
test_x86_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_x86_mac) ... ok
test_asset_tag (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_asset_tag) ... ok
test_bmc_mac (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_bmc_mac) ... ok
test_crc_matched (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_crc_matched)
Tests that the EEPROM CRC16 checksum matches. ... ok
test_extended_mac_base (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_extended_mac_base) ... ok
test_local_mac (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_local_mac) ... ok
test_location_on_fabric (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_location_on_fabric) ... ok
test_odm_pcb (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_odm_pcb) ... ok
test_product_name (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_product_name)
Tests if the platform defined product name is present ... ok
test_product_part_number (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_product_part_number) ... ok
test_product_serial_number (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_product_serial_number) ... ok
test_switch_asic_mac (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_switch_asic_mac) ... ok
test_system_manufacturer (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_system_manufacturer) ... ok
test_version (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_version) ... ok
test_x86_mac (tests.acctonbmc.test_eeprom.RackMonEepromTest.test_x86_mac) ... ok
test_asset_tag (tests.acctonbmc.test_eeprom.SCMEepromTest.test_asset_tag) ... ok
test_bmc_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_bmc_mac) ... ok
test_crc_matched (tests.acctonbmc.test_eeprom.SCMEepromTest.test_crc_matched)
Tests that the EEPROM CRC16 checksum matches. ... ok
test_extended_mac_base (tests.acctonbmc.test_eeprom.SCMEepromTest.test_extended_mac_base) ... ok
test_local_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_local_mac) ... ok
test_location_on_fabric (tests.acctonbmc.test_eeprom.SCMEepromTest.test_location_on_fabric) ... ok
test_odm_pcb (tests.acctonbmc.test_eeprom.SCMEepromTest.test_odm_pcb) ... ok
test_product_name (tests.acctonbmc.test_eeprom.SCMEepromTest.test_product_name)
Tests if the platform defined product name is present ... ok
test_product_part_number (tests.acctonbmc.test_eeprom.SCMEepromTest.test_product_part_number) ... ok
test_product_serial_number (tests.acctonbmc.test_eeprom.SCMEepromTest.test_product_serial_number) ... ok
test_switch_asic_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_switch_asic_mac) ... ok
test_system_manufacturer (tests.acctonbmc.test_eeprom.SCMEepromTest.test_system_manufacturer) ... ok
test_version (tests.acctonbmc.test_eeprom.SCMEepromTest.test_version) ... ok
test_x86_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_x86_mac) ... ok

----------------------------------------------------------------------
Ran 42 tests in 16.802s

OK
root@bmc-oob:/run/tests2# python cit_runner.py --run-test tests.acctonbmc.test_rest_modbus_cmd
fail: rackmond: can't change to service directory: No such file or directory
test_modbus_cmd_post (tests.acctonbmc.test_rest_modbus_cmd.RestModbusCmdTest.test_modbus_cmd_post) ... ok
test_modbus_cmd_post_microbench (tests.acctonbmc.test_rest_modbus_cmd.RestModbusCmdTest.test_modbus_cmd_post_microbench) ... ok
fail: rackmond: can't change to service directory: No such file or directory

----------------------------------------------------------------------
Ran 2 tests in 34.487s

OK
root@bmc-oob:/run/tests2# python cit_runner.py --run-test tests.acctonbmc.test_usb_host
test_usb_devices (tests.acctonbmc.test_usb_host.USBHostDeviceTest.test_usb_devices) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.020s

OK

@meta-cla meta-cla Bot added the CLA Signed label Jun 11, 2026
Signed-off-by: Louis Maliyam <louis@nexthop.ai>
@louis-nexthop
louis-nexthop force-pushed the fix-acctonbmc-cit-failures branch from 64b7734 to 0693d97 Compare June 11, 2026 07:32
@meta-codesync

meta-codesync Bot commented Jun 11, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D108253300. (Because this pull request was imported automatically, there will not be any future comments.)

@louis-nexthop

Copy link
Copy Markdown
Contributor Author

FYI @tao-ren

@louis-nexthop louis-nexthop changed the title acctonbmc: Fix CIT failures (test_bmc_mac, test_eeprom, test_wedge_power) acctonbmc: Add WEDGE800{B|C}NHP support to CIT Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant