💄 app: implement app theme for base - #1112
Conversation
🦋 Changeset detectedLatest commit: a512bd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR adds Base-specific theme tokens, chain-aware theme selection, branded card/home rendering, and updated swap token filtering and empty-state handling with new localized copy. ChangesBase-aware app theming
Swap token selection
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c6706412-2a35-414b-8ab3-59a13238aaf9
⛔ Files ignored due to path filters (2)
src/assets/images/card-bg-base.svgis excluded by!**/*.svgsrc/assets/images/card-signature-base.svgis excluded by!**/*.svg
📒 Files selected for processing (23)
.changeset/clever-crews-pay.md.changeset/true-bottles-cough.mdapp.config.tscommon/wagmi.config.tssrc/app/+html.tsxsrc/app/_layout.tsxsrc/assets/images/types.d.tssrc/components/card/CardDetails.tsxsrc/components/card/exa-card/CardContents.tsxsrc/components/card/exa-card/ExaCard.tsxsrc/components/context/ThemeProvider.tsxsrc/components/home/CardStatus.tsxsrc/components/home/VisaSignatureBanner.tsxsrc/components/home/VisaSignatureSheet.tsxsrc/components/shared/Skeleton.tsxsrc/components/swaps/SelectorModal.tsxsrc/components/swaps/Swaps.tsxsrc/i18n/es-AR.jsonsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/lifi.tssvgr.config.cjstamagui.config.ts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b75aa89e5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
- Coverage 70.69% 70.44% -0.26%
==========================================
Files 263 264 +1
Lines 11446 11548 +102
Branches 3833 3890 +57
==========================================
+ Hits 8092 8135 +43
- Misses 3059 3118 +59
Partials 295 295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8bd2b528-af9d-4e78-8993-05c463a283fd
📒 Files selected for processing (18)
.changeset/clever-crews-pay.mdcommon/wagmi.config.tssrc/app/+html.tsxsrc/app/_layout.tsxsrc/assets/images/types.d.tssrc/components/card/CardDetails.tsxsrc/components/card/exa-card/CardContents.tsxsrc/components/card/exa-card/ExaCard.tsxsrc/components/context/ThemeProvider.tsxsrc/components/home/CardStatus.tsxsrc/components/home/VisaSignatureBanner.tsxsrc/components/home/VisaSignatureSheet.tsxsrc/components/shared/Skeleton.tsxsrc/i18n/es-AR.jsonsrc/i18n/es.jsonsrc/i18n/pt.jsonsvgr.config.cjstamagui.config.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9fb2ba6c6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 87cf8455-f61b-46bb-b008-36c6d6bc185f
⛔ Files ignored due to path filters (2)
src/assets/images/card-bg-base.svgis excluded by!**/*.svgsrc/assets/images/card-signature-base.svgis excluded by!**/*.svg
📒 Files selected for processing (22)
.changeset/clever-crews-pay.md.changeset/true-bottles-cough.mdcommon/wagmi.config.tssrc/app/+html.tsxsrc/app/_layout.tsxsrc/assets/images/types.d.tssrc/components/card/CardDetails.tsxsrc/components/card/exa-card/CardContents.tsxsrc/components/card/exa-card/ExaCard.tsxsrc/components/context/ThemeProvider.tsxsrc/components/home/CardStatus.tsxsrc/components/home/VisaSignatureBanner.tsxsrc/components/home/VisaSignatureSheet.tsxsrc/components/shared/Skeleton.tsxsrc/components/swaps/SelectorModal.tsxsrc/components/swaps/Swaps.tsxsrc/i18n/es-AR.jsonsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/lifi.tssvgr.config.cjstamagui.config.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7371e16b30
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
♻️ Duplicate comments (2)
src/components/shared/Skeleton.tsx (1)
7-8: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winHandle compound Tamagui theme names here.
Line 8 only treats the literal
"dark"as dark.useThemeName()can resolve compound names, so nested dark themes will fall back to the light skeleton variant.src/components/card/CardDetails.tsx (1)
36-41: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winNormalize the Tamagui theme name before branching on light vs dark.
Lines 36-41 switch this component to
useThemeName(), but the later logo branches still rely on exact"light"checks. Compound names like"dark_*"will take the light-logo path.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: af8985a7-e963-4b5a-aec6-c2741157ad2e
⛔ Files ignored due to path filters (5)
src/assets/images/card/card-bg-base.svgis excluded by!**/*.svgsrc/assets/images/card/card-bg.svgis excluded by!**/*.svgsrc/assets/images/card/card-signature-base.svgis excluded by!**/*.svgsrc/assets/images/card/card-signature.svgis excluded by!**/*.svgsrc/assets/images/card/card.svgis excluded by!**/*.svg
📒 Files selected for processing (24)
.changeset/clever-crews-pay.md.changeset/true-bottles-cough.mdcommon/wagmi.config.tssrc/app/+html.tsxsrc/app/_layout.tsxsrc/assets/images/card/svgr.config.mjssrc/assets/images/types.d.tssrc/components/card/CardDetails.tsxsrc/components/card/exa-card/CardContents.tsxsrc/components/card/exa-card/ExaCard.tsxsrc/components/context/ThemeProvider.tsxsrc/components/home/CardStatus.tsxsrc/components/home/VisaSignatureBanner.tsxsrc/components/home/VisaSignatureSheet.tsxsrc/components/shared/Skeleton.tsxsrc/components/swaps/SelectorModal.tsxsrc/components/swaps/Swaps.tsxsrc/i18n/es-AR.jsonsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/lifi.tssvgr.config.mjstamagui.config.tstsconfig.json
feee0a6 to
1411a0b
Compare
2dd26d4 to
06597bf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06597bf67f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cab96e2d63
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
b445eb6 to
3b8e0cb
Compare
356e2cb to
47ffad8
Compare
3c58e45 to
5e892d6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e892d681a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
91e36bd to
2e63ed0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e63ed089d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ...config.transformer, | ||
| babelTransformerPath: require.resolve("react-native-svg-transformer/expo"), | ||
| }, | ||
| transformer: { ...base.transformer, babelTransformerPath: require.resolve("./metro.config.cjs") }, |
There was a problem hiding this comment.
Because getSentryExpoConfig(..., { annotateReactComponents: true }) has already put Sentry's Babel transformer into base.transformer, replacing babelTransformerPath here means that transformer is no longer in the chain; the transform function below delegates ordinary TS/JS files to react-native-svg-transformer/expo, so production bundles lose the data-sentry-component annotations used for React component names. Sentry's Expo docs specifically warn not to overwrite this path; apply/wrap Sentry after installing the custom SVG transformer instead.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49cb7d352f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| borderColorFocus: "transparent", | ||
| borderColorPress: "transparent", | ||
| outlineColor: "", | ||
| ...(isBase && baseLight), |
There was a problem hiding this comment.
Because common/wagmi.config.ts emits isBase as a boolean, this expression has type false | typeof baseLight; TypeScript rejects spreading the false branch, so the root test:ts target fails before the app can build. Use an object-shaped fallback such as ...(isBase ? baseLight : {}).
Useful? React with 👍 / 👎.
00299cf to
f87f0ee
Compare
d663aae to
8f28d16
Compare
1 participant
closes #1044
Summary by CodeRabbit
New Features
Bug Fixes