Fix due command undercounting due cards - #199
Open
oddish3 wants to merge 2 commits into
Open
Conversation
`print_due` called `Database::due_on`, which matches only cards whose due_date is exactly the given date. This misses never-reviewed cards (due_date is NULL) and overdue cards (due_date before the given date), both of which a drill session would still pull in via `all_due`. Switch `due` to use `all_due` so it reports what a drill session would actually select. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
eudoxia0
reviewed
Aug 5, 2026
Owner
|
Ok so New cards are kind of an edge case. If I'm doing But if I'm doing |
Author
|
Fair point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print_duecalledDatabase::due_on, which matches only cards whose due_date is exactly the given date.This misses never-reviewed cards (due_date is NULL) and overdue cards (due_date before the given date), both of which a drill session would still pull in via
all_due.Switching
dueto useall_dueso it reports what a drill session would actually select.