fix(spec): QM audit remediation — German duties, missing stories, link separators - #18
Conversation
…k separators
L0 User Stories
- Translate German Duties sections to English in all 10 agent user stories
(us_change_mgr, us_project_mgr, us_quality_mgr, us_system_designer,
us_dev_engineer, us_test_engineer, us_quality_mece, us_release_engineer,
us_verify_engineer, us_setup_engineer)
- Fix non-human actors in us_skill_orchestration ('syspilot manager agent'
→ 'syspilot user') and us_skill_branching ('syspilot agent' → 'syspilot user')
- Add missing SYSP_US_INSTALLER user story as dedicated file us_installer.rst;
remove duplicate inline story from us_setup_engineer.rst (avoids sphinx-needs
duplicate-ID build error — upstream reqs already reference SYSP_US_INSTALLER)
- Add missing SYSP_US_JARVIS user story (us_jarvis.rst)
- Add missing SYSP_US_SCHEMA user story (us_schema_check.rst)
- Fix semicolons → commas in :links: of us_skill_impact.rst
- Update userstories/index.rst with new entries
L1 Requirements
- Fix semicolons → commas in :links: across all req files (13 files,
~20 instances): req_project_mgr, req_change_mgr, req_dev_engineer,
req_quality_mgr, req_verify_engineer, req_release_engineer, req_quality_mece,
req_quality_trace, req_test_engineer, req_docu_engineer, req_system_designer,
req_setup_engineer, req_skill_impact
- Add req_jarvis.rst with SYSP_REQ_JARVIS_TOOL, SYSP_REQ_JARVIS_CONTRACT,
SYSP_REQ_JARVIS_FRONTMATTER
- Update requirements/index.rst with req_jarvis entry
L2 Design Specs
- Fix semicolons → commas in :links: across 4 spec files (spec_agent_arch,
spec_skill_ask_questions, spec_skill_branching, spec_skill_orchestration,
spec_skill_impact)
- SYSP_SPEC_CM_FRONTMATTER: add syspilot.verify to agents list
- SYSP_SPEC_VERIFY_FRONTMATTER: promote status draft → approved
- SYSP_SPEC_DESIGN_SOUL + SYSP_SPEC_DESIGN_DUTIES: correct tags change → design
- SYSP_SPEC_DOC_COPILOT_INSTRUCTIONS: correct status open → draft
|
Thank you @hubertusgbecker — this is an impressive piece of work. A full independent QM audit across all three spec levels is exactly the kind of systematic quality review we've been wanting but haven't had bandwidth for. The findings are real and the fixes are correct. What we've already addressed since you branched (2026-06-03): Your branch is based on
Request: please rebase onto current Could you rebase Once rebased, we'll review and merge — this is going into the next release. Thanks again — this is exactly the kind of contribution that makes syspilot better for everyone using it. |
Summary
QM audit remediation across all three specification levels. This PR fixes
structural gaps found during an independent quality audit of the specification
hierarchy. All fixes are targeted and non-destructive — no spec IDs are renamed
or removed, no behavior is changed.
Problem Statement
The specification hierarchy had four classes of structural defects that silently
degraded spec quality and build reliability:
SYSP_US_INSTALLER,SYSP_US_JARVIS,SYSP_US_SCHEMASYSP_US_INSTALLERwhich did not exist:links::links:is comma, not semicolonAdditionally, four targeted L2 spec gaps:
SYSP_SPEC_CM_FRONTMATTERsyspilot.verifymissing from CM agents list — verify engineer is a CM-dispatched engineerSYSP_SPEC_VERIFY_FRONTMATTERdraft— content is fully specified and implementedSYSP_SPEC_DESIGN_SOUL/SYSP_SPEC_DESIGN_DUTIESchange→design— System Designer is adesigndomain agent, not achangedomain agentSYSP_SPEC_DOC_COPILOT_INSTRUCTIONSopen→draft—openis not a valid status inubproject.tomlChanges
L0 — User Stories (13 files)
German duties → English (
us_change_mgr,us_project_mgr,us_quality_mgr,us_system_designer,us_dev_engineer,us_test_engineer,us_quality_mece,us_release_engineer,us_verify_engineer,us_setup_engineer):Non-human actors:
us_skill_orchestration:"syspilot manager agent"→"syspilot user"us_skill_branching:"syspilot agent"→"syspilot user"New story files:
us_installer.rst—SYSP_US_INSTALLER: critical — 8 existing reqs inreq_setup_engineer.rstalready link to this ID; the missing file was a livesphinx-needs build error. The inline duplicate in
us_setup_engineer.rstisremoved and replaced with a cross-reference note.
us_jarvis.rst—SYSP_US_JARVIS: documents the Jarvis inter-agentcommunication mechanism already referenced in PM/CM/QM agent frontmatters
us_schema_check.rst—SYSP_US_SCHEMA: documents the QM schema validationcheck (third check in the MECE + Trace + Schema audit trio)
Semicolons in
:links::us_skill_impact.rst: 3 semicolons → commasIndex update:
us_installer,us_jarvis,us_schema_checkadded touserstories/index.rstL1 — Requirements (14 files)
Semicolons → commas in
:links:(sphinx-needs requires comma as separator):req_project_mgr.rstreq_change_mgr.rstreq_quality_mgr.rstreq_setup_engineer.rstreq_dev_engineer.rstreq_verify_engineer.rstreq_release_engineer.rstreq_quality_mece.rstreq_quality_trace.rstreq_test_engineer.rstreq_docu_engineer.rstreq_system_designer.rstreq_skill_impact.rstNew file:
req_jarvis.rstwith three requirements:SYSP_REQ_JARVIS_TOOL— thesyspilot_jarvis_toolsmessaging toolSYSP_REQ_JARVIS_CONTRACT— message payload structure contractSYSP_REQ_JARVIS_FRONTMATTER— per-agent frontmatter declaration requirementIndex update:
req_jarvisadded torequirements/index.rstL2 — Design Specs (5 files)
Semicolons → commas in
:links:(5 files):spec_agent_arch,spec_skill_ask_questions,spec_skill_branching,spec_skill_orchestration,spec_skill_impactTargeted spec fixes:
SYSP_SPEC_CM_FRONTMATTER"syspilot.verify"to agents listSYSP_SPEC_VERIFY_FRONTMATTERstatus: draft→status: approvedSYSP_SPEC_DESIGN_SOULtags: …, change, soul→tags: …, design, soulSYSP_SPEC_DESIGN_DUTIEStags: …, change, duties→tags: …, design, dutiesSYSP_SPEC_DOC_COPILOT_INSTRUCTIONSstatus: open→status: draftVerification
:links:semicolons across alldocs/syspilot/**/*.rstSYSP_US_INSTALLERexists as a standalone file and is removed from the inline position inus_setup_engineer.rstSYSP_US_JARVISandSYSP_US_SCHEMAexist and are indexedSYSP_REQ_JARVIS_*files exist and link upward toSYSP_US_JARVISsyspilot.verifypresent in CM agents liststatus: open(not a valid status value)development— no fork-specific commits includedDeferred (out of scope for this PR)
SYSP_REQ_INSTALLER_SOUL/SYSP_REQ_INSTALLER_FRONTMATTERadditionsreq_jarvis.rstL2 design specsSYSP_SPEC_VERIFY_FRONTMATTER