Use Reflection.Emit accessors when dynamic code is supported - #487
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0bba94e9-a444-4146-957b-dcc6fb2d9b56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
Reflection.Emitmember accessors as the default whenever dynamic code is supported, mirroring dotnet/runtime#131452. This reverts the accessor-selection portion of #473 while retaining its reflection invocation and exception-propagation changes.The
IsDynamicCodeCompiledgate assumed emitted IL offered no throughput benefit under interpreters. The measurements behind dotnet/runtime#131452 show that interpretedDynamicMethodaccessors substantially outperform repeated reflection invocation, so the default now usesIsDynamicCodeSupportedand the unused compatibility helper is removed.Validation:
make test