compact/calibrations.xml: update IRT configurations to latest - #1149
Open
veprbl wants to merge 1 commit into
Open
compact/calibrations.xml: update IRT configurations to latest#1149veprbl wants to merge 1 commit into
veprbl wants to merge 1 commit into
Conversation
11 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates EPIC’s calibration download configuration to use the latest IRT2 reconstruction JSONs from eic/epic-data, while renaming the locally cached reco JSON filenames to _v2 to avoid accidental use of older configurations.
Changes:
- Update IRT2 DRICh/PFRICh reco JSON URLs to a newer
epic-datacommit. - Rename locally cached reco JSON paths to
*_reco_v2.jsonincompact/calibrations.xml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+69
to
+70
| <arg value="file:calibrations/irt2/drich-reco_v2.json"/> | ||
| <arg value="url:https://raw.githubusercontent.com/eic/epic-data/03b9594f743be82d05176d662b93a499b6362e2e/irt2/drich-reco.json"/> |
wdconinc
approved these changes
Aug 7, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
eic/epic-data#37
OutputRootFileis removed because otherwise irt2 unconditionally creates an output file.Calibrationrelative path was updated for reconstruction to be able to pick up the calibration files.I also add _v2 suffix, and plan to change the path in EICrecon, this is the easiest way to ensure that no one uses old files by default. There might be some issues with old files, namely display mode is enabled, and it may crash with older irt2 under certain conditions.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply