feat: impose time and track length limit for optical photons in DIRC - #1133
Open
wdconinc wants to merge 2 commits into
Open
feat: impose time and track length limit for optical photons in DIRC#1133wdconinc wants to merge 2 commits into
wdconinc wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds DD4hep region limits to the DIRC geometry to terminate long-lived optical photons by enforcing maximum propagation time and maximum track length, addressing the simulation pathology of extremely long optical-photon trajectories discussed with the DIRC DSC.
Changes:
- Define a
DIRCRegionLimitslimitset withtime_maxandtrack_length_maxapplying specifically toopticalphoton. - Attach
DIRCRegionLimitstoDIRCRegionvia<limitsetref>, so the DIRC detector’s assigned region enforces these limits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
topic: barrel
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Based on discussions with the DIRC DSC, this solution is preferred over #1113.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
This is intended for July campaign inclusion.