perf(DRICH): share CarbonSegment logical volumes within each crown ring - #1117
Open
wdconinc wants to merge 2 commits into
Open
perf(DRICH): share CarbonSegment logical volumes within each crown ring#1117wdconinc wants to merge 2 commits into
wdconinc wants to merge 2 commits into
Conversation
Within each aerogel corona ring, all phi-segments have identical ConeSegment shape and material. Create one logical volume per ring and place it numSegments times with RotationZ, rather than creating ~82 unique TGeoVolume objects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes DRICH aerogel corona support geometry by reusing one CarbonSegment logical volume per crown ring and placing it repeatedly with azimuthal rotations, reducing redundant logical volume creation while preserving the segment geometry.
Changes:
- Replaces per-phi
ConeSegment/Volumeconstruction with one shared segment volume per crown ring. - Places each shared segment volume
Ntimes usingRotationZ(p * segmentSpacing). - Simplifies segment naming to one logical volume name per crown ring.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Within each aerogel corona ring, all phi-segments of the CarbonSegment structural support share the
same ConeSegment shape and material. This PR creates one logical volume per ring and places it N
times with azimuthal rotations, reducing ~82 unique TGeoVolume objects to one per crown ring (~5).
Identified via analysis of geometry DOT file from npdet_to_dot.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
GitHub Copilot was used to identify the pattern and draft the refactoring.