12-Sector-CyMBaL - #2829
Conversation
… DD4hep #f7904caf. - Digitization; + Add the 12-sector CyMBaL segmentation scheme to the list of valid schemes. + DeadZone rejection: if enabled, applies simultaneoulsy to both 2DStrips. Active being #strips * pitch. - Plugin (if "MPGDTrackerDigi" factory): + Resolutions (config parameter) read from XML, if available. + New "hasDeadZone" boolean config parameter (set =true for CyMBaL).
for more information, see https://pre-commit.ci
|
As usual, we will need the PR for epic geometry as well. And as before, I would really appreciate any help with reviewing this. I assume this is backwards compatible? Or we just rely on the fact that strip geometry is not used in the production? |
This reminds me of a known regression from three weeks ago that should be fixed on current main via #2745. Have you tested with most up to date version of your branch? |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/31011440068. Please merge this PR into the branch `12-Sector-CyMBaL-compatible` to resolve failures in PR #2829. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Capybara summary for PR 2829
Last updated 2026-08-05T12:39-04:00 d41b283 |
|
Hello,
Everything was up-to-date. (I managed to find a work around the absence of TOF |
|
To ease the task of the reviewers, here is a breakdown of the modifications to the source code: TWO files, mainly, are concerned: I) "MPGDTrackerDigi": THREE sets of modifications:
ii) DeadZone:
iii) Fulfilling requests from github actions, like "gsl::at", avoid casting II) MPGD plugin: configuration parameters: |


Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
New version of MPGD plugin and digitization compatible w/ upcoming 12-Sector-CyMBaL (see "https://github.com/eic/epic/tree/12-Sector-CyMBaL").
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
None.