Update fetch.py - #94
Open
siffalo wants to merge 1 commit into
Open
Conversation
We at Crocus LLC have a recommended requirement from South Carolina Department of Education to use lightbeam in an application we're developing for them. It's been working well to date, both sending and fetching data. However, when we get into advanced use cases of the Ed-Fi API via lightbeam, it lacks support for resource endpoint fetch/query parameters by reference, only by name. The most critical fetch/query parameter we need at the moment is minChangeVersion, and of course it's a parameter by reference, not by name, for all resource endpoints. So either we shift away from lightbeam in these advanced use cases, we use our own fork of lightbeam (not clear at the moment whether a custom lightbeam deployment would be acceptable at SCDE), or we try to get lightbeam to include support for query parameters by reference. You know your swagger model better than I and my morning with it, so this could probably be optimized, but just getting a suggested code change to you, if you'd consider support for query parameters by reference. With this change, I can use minChangeVersion successfully, and of course all other query parameters by reference.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We at Crocus LLC have a recommended requirement from South Carolina Department of Education to use lightbeam in an application we're developing for them. It's been working well to date, both sending and fetching data. However, when we get into advanced use cases of the Ed-Fi API via lightbeam, it lacks support for resource endpoint fetch/query parameters by reference, only by name. The most critical fetch/query parameter we need at the moment is minChangeVersion, and of course it's a parameter by reference, not by name, for all resource endpoints. So either we shift away from lightbeam in these advanced use cases, we use our own fork of lightbeam (not clear at the moment whether a custom lightbeam deployment would be acceptable at SCDE), or we try to get lightbeam to include support for query parameters by reference. You know your swagger model better than I and my morning with it, so this could probably be optimized, but just getting a suggested code change to you, if you'd consider support for query parameters by reference. With this change, I can use minChangeVersion successfully, and of course all other query parameters by reference.