Fix Modbus Serial - #84
Open
bobur-khay wants to merge 6 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
Seems to be outdated now? There is no localhost fallback I see in the code? Also, you can bump the patch version in package.json |
egekorkan
reviewed
Jul 31, 2026
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install prettier | ||
| run: npm install prettier@2.3.2 |
Member
There was a problem hiding this comment.
@bobur-khay what is the reason for change? We kept having problems with prettier versioning before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code generator for Modbus Serial in JS had a line of code:
new URL(href)When
href: "/"thenew URL()was throwing anInvalid URL.Fix:
hrefis/it falls back tolocalhostnow