mw/com: Mark skeleton_recreation_test as flaky - #861
Open
gdadunashvili wants to merge 1 commit into
Open
Conversation
Test fails regularly when running on qnx-8 due to a bug in inotify in which we receive spurious inotify events. To be reevaluated once the bug is fixed or service discovery is reimplemented to not rely on inotify events.
gdadunashvili
force-pushed
the
dadu_mark_skeleton_recreation_test_as_flaky
branch
from
August 6, 2026 11:06
3c24194 to
861d4d0
Compare
gdadunashvili
marked this pull request as ready for review
August 6, 2026 11:07
gdadunashvili
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
August 6, 2026 11:07
limdor
reviewed
Aug 6, 2026
| # service discovery is reimplemented to not rely on | ||
| # inotify events (SWP-214271). | ||
| target_compatible_with = ["@platforms//os:linux"], | ||
| flaky = True, |
Contributor
There was a problem hiding this comment.
I guess it is not possible to do a select statement in the flaky flag? With this change we are kind of accepting that in linux it could be flaky. On the other side without this change, we would not notice a reliably failing test on qnx.
If you coult try a select statement on flaky and see what Bazel says it would be great. Probably it is not a configurable flag and it will not work, but we could consider asking it as a feature request to Bazel if that is the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test fails regularly when running on qnx-8 due to a bug in inotify in which we receive spurious inotify events. To be reevaluated once the bug is fixed or service discovery is reimplemented to not rely on inotify events.