Skip to content

chore: adopt @score_cpp_policies//coverage in communication - #604

Draft
olivembo wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:adopt-score-cpp-policies-coverage
Draft

chore: adopt @score_cpp_policies//coverage in communication#604
olivembo wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:adopt-score-cpp-policies-coverage

Conversation

@olivembo

Copy link
Copy Markdown

Summary

Replaces the local copies of merger.py, reporter.py, justify.py and effective_coverage.py
with the centralized tooling from @score_cpp_policies//coverage.

The --coverage_report_generator flag and the reporter_wrapper target name are unchanged, so existing CI scripts need no adjustment.

Changes

  • MODULE.bazel: add score_cpp_policies as dev dependency via git_override (PR9 in score_cpp_policies, to be replaced with a version tag after merge); bump aspect_rules_lint 2.3.0 -> 2.5.0
  • coverage.bazelrc: switch --coverage_output_generator to @score_cpp_policies//coverage:merger
  • llvm_cov/BUILD: replace four py_binary targets and the genrule wrapper with score_coverage_reporter + score_instrumented_sources_manifest
  • generate_coverage_html.sh: update justify and effective_coverage invocations to @score_cpp_policies//coverage:*
  • deleted: merger.py, reporter.py, justify.py, effective_coverage.py, filter_regexes.txt

Depends on

eclipse-score/score_cpp_policies#9 which must be merged and released before the git_override can be replaced with a version tag.

…pstream

The coverage tools (merger, reporter, justify, effective_coverage) were
maintained as local copies in quality/coverage/llvm_cov/. Now that they
live in @score_cpp_policies, this commit wires in the upstream versions.

Changes:
- MODULE.bazel: add score_cpp_policies dev dependency (git_override
  pointing to PR eclipse-score#9 (eclipse-score/score_cpp_policies#9), to be replaced with a version tag after merge)
- MODULE.bazel: bump aspect_rules_lint 2.3.0 -> 2.5.0 (required by
  score_cpp_policies)
- coverage.bazelrc: switch --coverage_output_generator to
  @score_cpp_policies//coverage:merger
- llvm_cov/BUILD: replace four py_binary targets and the genrule wrapper with score_coverage_reporter + score_instrumented_sources_manifest macros
- generate_coverage_html.sh: update justify and effective_coverage invocations to @score_cpp_policies//coverage:*
- delete merger.py, reporter.py, justify.py, effective_coverage.py, filter_regexes.txt since all moved upstream
- llvm_cov/README.md: updated to reflect the new structure

The --coverage_report_generator flag and the reporter_wrapper target
name are unchanged, so existing CI scripts need no adjustment.
@anmittag

Copy link
Copy Markdown
Member

@olivembo some checks require your adaptions

@anmittag anmittag moved this from Backlog to Ready in COM - Communication FT Jul 21, 2026
@olivembo
olivembo marked this pull request as draft July 21, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

2 participants