Assert no console instances are existing before and after console tests - #2852
Merged
iloveeclipse merged 1 commit intoAug 4, 2026
Merged
Conversation
Contributor
It seems that we either have race condition in ConsoleManager & related code, or that some tests "leak" created Console instances and they are popping around at unexpected times in other tests. Let forcibly remove all Consoles in all tests related to ConsoleManager and let assume before the test there are no Console instances flying around. See eclipse-platform#2849 (comment)
iloveeclipse
force-pushed
the
console_tests_fixes
branch
from
August 4, 2026 20:53
e404929 to
b28ce03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we either have race condition in ConsoleManager & related code, or that some tests "leak" created Console instances and they are popping around at unexpected times in other tests.
Let forcibly remove all Consoles in all tests related to ConsoleManager and let assume before the test there are no Console instances flying around.
See #2849 (comment)