Report per operation timings in the editor performance tests - #4230
Open
vogella wants to merge 1 commit into
Open
Report per operation timings in the editor performance tests#4230vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
OpenCloseEditorTest measured opening and closing in one block and EditorSwitchTest measured twelve switches in another, so a change in a single operation could not be attributed. Both tests now time the individual operations and print min, median, 90th percentile and maximum via the new UIPerformanceTestUtil.reportTimings, which is the only output available when no performance database is configured. Both tests warm up before measuring so that class loading and JIT no longer land in the first measured block, and both are bounded by time instead of a fixed iteration count. EditorSwitchTest drops from about 145 to 35 seconds while collecting more samples than before. The recorded series are unchanged: the number of operations per measurement block stays the same, as does the "UI - Open/Close Editor" summary tag.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor performance tests measured opening plus closing in a single block, and twelve editor switches in another, so a change in one operation could not be attributed, and nothing at all was printed when no performance database is configured. Both tests now time the individual operations and log min, median, 90th percentile and maximum, they warm up before measuring so that class loading and JIT no longer land in the first measured block, and they are bounded by time instead of a fixed iteration count. EditorSwitchTest drops from roughly 145 to 35 seconds while collecting more samples than before.
The recorded series are unchanged, so the existing performance database path and the "UI - Open/Close Editor" summary keep working as before.
This is a first step towards measuring and then improving editor handling. Sample output of a local run: