[Build] Run API check and javadoc only once per operating system - #3485
Merged
akurtakov merged 1 commit intoAug 6, 2026
Merged
Conversation
The reusable build workflow always passed -Papi-check and -Pjavadoc, so both ran in all six PR jobs. Neither depends on the GTK version, the GDK backend or the target architecture, only on the Java sources, so the three Linux jobs and the two macOS jobs computed identical results. A new boolean input api_check (default false) now gates the two profiles, and maven.yml enables it for one job per operating system: gtk3/x11 on Linux, the single Windows job and aarch64 on macOS. The API surface still differs between the gtk, win32 and cocoa fragments, so the check stays per operating system. Fixes eclipse-platform#3484
Contributor
Member
|
The compiler warnings are unrelated and TBH I have no clue why they appear (it's not the first time in my experience). Merging despite them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable build workflow always passed
-Papi-check -Pjavadoc, so the API tools check and the javadoc generation ran in all six PR jobs. Neither depends on the GTK version, the GDK backend or the target architecture, only on the Java sources, so the three Linux jobs and the two macOS jobs were computing identical results. I verified the macOS case rather than assuming it: the two cocoa fragments compile the same source folders and their jars contain an identical set of 768 class files with identical sizes and an identical.api_descriptionapart from the component id.A new boolean input
api_check(default false) now gates both profiles, andmaven.ymlenables it for exactly one job per operating system: gtk3/x11 on Linux, the single Windows job and aarch64 on macOS. That takes the API check and javadoc from six runs down to three, which cuts a few minutes off the slowest jobs without losing any coverage. Unlike most Eclipse repos, SWT does have a genuinely different API surface per gtk/win32/cocoa fragment, so the check deliberately stays per operating system instead of collapsing to a single global run.Fixes #3484