Fix Jetty container context path handling - #6116
Draft
zenios wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Dimitris Zenios <dimitris.zenios@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JettyHttpContainermounted at both root and non-root context pathsRoot cause
JettyHttpContainerused the full request path while also deriving its base URI from the Jetty context path. A request for/context/resourcewas therefore constructed as/context/context/resourceand failed resource matching.Using
Request.getPathInContext(request)preserves the context path in the base URI while appending only the part of the request path that is relative to that context.Impact
Jersey resources mounted under a non-root Jetty
ContextHandlernow route correctly. Root-context routing remains unchanged,UriInfoexposes the expected base and request URIs, and query parameters are preserved.Testing
mvnd -pl containers/jetty-http -am test -DskipTests=false/but fails with404at/contextwithout the fixFixes #3338