Adopt sbt-zipx 0.1.6 typed API and sbt 2.0.5 - #22
Open
russwyte wants to merge 2 commits into
Open
Conversation
zipx 0.1.6 replaces bare Strings in its public API with validated neotype types, so a typo'd capability name or JDK version is now a compile error instead of a runner failure. The fmt gate uses zipxTasks.once with the scalafmtCheckAll key, so renaming the task fails the build load. The Central publish command stays a literal SbtCommand because "release" is a command alias, not a task key. Generated workflows are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the org-wide sbt-zipx 0.1.6 sweep.
Changes
sbt.version2.0.4 -> 2.0.5sbt-zipx0.1.5 -> 0.1.6Typed API adoption
0.1.6 replaces bare
Strings across the zipx public API with validated neotype types, checked at compile time. This PR takes the safety rather than the minimum needed to compile:zipxJavaVersion := JdkVersion("25")fmtgate useszipxTasks.once(Fmt, scalafmtCheckAll)with the real sbt key, so renaming the task is a build-load error rather than a CI failurefmtis named once asval Fmt = CapabilityName("fmt")and reused inCapability.test.copy(needsCapabilities = ...), so a typo cannot silently produce a job that never runsZipxCentral.release.copy(command = _ => SbtCommand("release"))stays a literal becausereleaseis a command alias rather than a task keyFormatting follows this repo's convention of unaligned single-space
:=in sbt files.Verification
Generated workflows are byte-identical after regeneration (no diff under
.github/), which is the expected result: zipx's own.github/did not change between 0.1.5 and 0.1.6, so the typed rewrite is confirmed semantics-preserving.sbt "zipxWorkflowCheck; scalafmtCheckAll; testFull; scripted"all green, including+ marklit/run-resource.