Skip to content

[20274] Remove default port value in yaml address field - #191

Closed
David-LP99 wants to merge 2 commits into
mainfrom
feature/yaml_validator_participant_port_needed
Closed

[20274] Remove default port value in yaml address field#191
David-LP99 wants to merge 2 commits into
mainfrom
feature/yaml_validator_participant_port_needed

Conversation

@David-LP99

Copy link
Copy Markdown
Contributor

As part of the PR eProsima/DDS-Router#543, a few changes are needed in the Pipe to enforce the requirement of having a port tag as part of every element of listening-addresses and connection-addresses, in the Yaml configuration of the Discovery Server and Initial Peers participants.

The changes consist on throwing an exception when no port tag is present instead of assigning the default value, and updating the involved tests to account for this.

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@David-LP99
David-LP99 requested a review from Danipiza July 15, 2026 11:51
@David-LP99 David-LP99 changed the title [20274] Remove default 'port' value in yaml 'address' field [20274] Remove default port value in yaml address field Jul 15, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.06%. Comparing base (4cfd8cc) to head (8482054).

Files with missing lines Patch % Lines
ddspipe_yaml/src/cpp/YamlReader_types.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   37.98%   39.06%   +1.07%     
==========================================
  Files         177      160      -17     
  Lines       12751     7810    -4941     
  Branches     5844     3124    -2720     
==========================================
- Hits         4844     3051    -1793     
+ Misses       4793     3046    -1747     
+ Partials     3114     1713    -1401     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@David-LP99 David-LP99 closed this Jul 17, 2026
@David-LP99
David-LP99 deleted the feature/yaml_validator_participant_port_needed branch July 17, 2026 06:38
@Danipiza

Copy link
Copy Markdown
Contributor

This branch is closed to reopen with the same branch name as the feature/yaml_validation_v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants