fix: fix broken agent tests#62
Conversation
Updates test mocks and expectations in `src/__tests__/agent.test.ts` to reflect recent architectural changes: - `../env.js` moved to `../core/env.js` - `../logger.js` moved to `../core/logger.js` - `buildSetupWorkspaceTool` renamed to `buildWorkspaceTool` - `buildExecutorTool` replaced by `buildSessionTools` - Tool name changed from `executorTool` to `sendToSessionTool` - Added missing `stepCountIs` mock for AI SDK - Provided dummy `steps: []` array to mock resolution of `generateText` Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f270e55699
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| buildSessionTools: vi.fn().mockReturnValue({ | ||
| execute: vi.fn().mockResolvedValue('Executor called'), | ||
| }), |
There was a problem hiding this comment.
buildSessionTools is mocked to return only an execute function, but runAgentOrchestrator destructures captureSessionTool and sendToSessionTool from that return value. In this test, both become undefined, and toHaveProperty('sendToSessionTool') still passes because the key exists even when its value is undefined, so the test no longer validates tool wiring and can miss regressions where session tools are not passed correctly.
Useful? React with 👍 / 👎.
1 participant
Updates
src/__tests__/agent.test.tsto accommodate recent refactoring. Replaces old tool names (buildExecutorTool,buildSetupWorkspaceTool) with the current functions (buildSessionTools,buildWorkspaceTool), updates module imports for core utilities, and properly mocks AI SDK extensions (stepCountIs,stepsfield in response).PR created automatically by Jules for task 9099092676589609932 started by @hughlv